Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto convert using Grafana 11 dashboards #1068

Merged
merged 3 commits into from
Jun 28, 2024

Conversation

dougszumski
Copy link
Member

  • Load dashboards into Grafana 11 preview
  • View dashboard and export
  • Check in changes
    • Don't allow hard coded Prometheus datasources

Needs reviewing / testing.

@dougszumski dougszumski requested a review from a team as a code owner May 13, 2024 16:37
@markgoddard
Copy link
Member

"pluginVersion": "11.0.0-preview", looks a bit weird

@dougszumski
Copy link
Member Author

"pluginVersion": "11.0.0-preview", looks a bit weird

Yeah, 11.0.0 wasn't out then, but it is now (the main advantage for this is that it provides auto-conversion). Dawud did test that they would load back into 10.x.

We can remove -preview now.

@dougszumski
Copy link
Member Author

Please can you test this @technowhizz ?

I have switched to the non-preview plugin version.

Load a group of dashboards into Grafana 11, check that they
function and check in the changes.
These plots show integer quanties, so set decimals to 0. It isn't
clear where the -1 setting came from, but it breaks the plot entirely
on Grafana 11.
Copy link
Contributor

@technowhizz technowhizz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dougszumski dougszumski merged commit f9a9586 into stackhpc/2023.1 Jun 28, 2024
5 checks passed
@dougszumski dougszumski deleted the bugfix/INFRA-629-2 branch June 28, 2024 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants