Fail kolla image build when critical CVEs are detected #1080
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
assumptionsandg
approved these changes
Jun 19, 2024
Alex-Welsh
reviewed
Jun 21, 2024
markgoddard
approved these changes
Jun 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added condition in
scan-images.shto add images to additional listcritical-images.txtthat can be used to check if there was any critical CVEs found during image scanning.The container image build job will fail when critical CVEs are found from images but the push for other images will be performed.
Changed push dirty image option to false. (When it's set to true, images with critical CVEs will also get pushed and the job will not fail)