Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds seed_redfish_exporter_container #501

Merged
merged 15 commits into from
Jul 16, 2024
Merged

Adds seed_redfish_exporter_container #501

merged 15 commits into from
Jul 16, 2024

Conversation

jovial
Copy link
Contributor

@jovial jovial commented Apr 27, 2023

No description provided.

markgoddard
markgoddard reviewed May 30, 2023
View reviewed changes
Copy link
Member

@markgoddard markgoddard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still draft?

@jovial jovial marked this pull request as ready for review February 1, 2024 16:07
@jovial jovial requested a review from a team as a code owner February 1, 2024 16:07
jovial
jovial commented Feb 1, 2024
View reviewed changes
Copy link
Contributor Author

@jovial jovial left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My redfish exporter deployment was a bit broken at one customer site, so I updated this to fix my issues. Worked for me (TM)

etc/kayobe/kolla/config/prometheus/prometheus.yml.d/60-redfish.yml Show resolved Hide resolved
@Alex-Welsh
Copy link
Contributor

Merged Antelope into Yoga?

@cityofships cityofships changed the base branch from stackhpc/yoga to stackhpc/2023.1 April 15, 2024 12:28
@markgoddard markgoddard mentioned this pull request Apr 17, 2024
Open
markgoddard
markgoddard requested changes Apr 18, 2024
View reviewed changes
Copy link
Member

@markgoddard markgoddard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs a release note

etc/kayobe/stackhpc-monitoring.yml Outdated Show resolved Hide resolved
etc/kayobe/kolla/config/prometheus/prometheus.yml.d/60-redfish.yml Outdated Show resolved Hide resolved
markgoddard
markgoddard approved these changes Jul 16, 2024
View reviewed changes
Copy link
Member

@markgoddard markgoddard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's get this thing in.

@markgoddard markgoddard merged commit 1df10c3 into stackhpc/2023.1 Jul 16, 2024
11 of 12 checks passed
@markgoddard markgoddard deleted the feature/yoga/redfish-exporter branch July 16, 2024 13:54
@markgoddard
Copy link
Member

15 months later...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bbezak bbezak bbezak left review comments

@jackhodgkiss jackhodgkiss jackhodgkiss left review comments

@GregWhiteyBialas GregWhiteyBialas GregWhiteyBialas left review comments

@markgoddard markgoddard markgoddard approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@jovial @Alex-Welsh @markgoddard @bbezak @jackhodgkiss @GregWhiteyBialas