Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow configuration of the subnet the LB is placed in #287

Merged
merged 2 commits into from
May 14, 2024

Conversation

malt3
Copy link
Contributor

@malt3 malt3 commented Feb 14, 2024

This is an optional parameter that can either be left uninitialized to keep the old behavior or be set as a helm value or per LB.

We at edgeless systems have a use-case for yawol where we need the loadbalancer to be in the same network but a different subnet (cidr) than the kubernetes nodes.
This is a requirement for the network encryption we are using in our clusters.
Basically, we need to enforce that any traffic in the node subnet cidr belongs to a k8s node (and can thus enforce it to be encrypted).
Loadbalancer traffic must therefore be part of a separate subnet.

@dergeberl
Copy link
Member

Thanks for your contribution 🥳

Can you please add a test to check that createPort is correct if there is a subnet set and if there is no subnet set?

@malt3
Copy link
Contributor Author

malt3 commented Feb 16, 2024

Can you please add a test to check that createPort is correct if there is a subnet set and if there is no subnet set?

I added tests for the loadbalancermachine controller behavior. Please let me know if there is more testing needed!

@dergeberl
Copy link
Member

I added tests for the loadbalancermachine controller behavior. Please let me know if there is more testing needed!

Can you please add one more test for the yawol-cloud-controller. To test that it also works that a subnet can be set via an annotation.
Like this:

It("should update the defaultNetwork field", func() {

Copy link
Member

@Kumm-Kai Kumm-Kai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution 😍, just a few additional comments 🙂

api/v1beta1/loadbalancer_types.go Outdated Show resolved Hide resolved
cmd/yawol-cloud-controller/main.go Outdated Show resolved Hide resolved
malt3 added 2 commits May 14, 2024 11:27
This is an optional parameter that can either be left uninitialized to
keep the old behavior or be set as a helm value or per LB.
@Kumm-Kai Kumm-Kai merged commit cf9e736 into stackitcloud:main May 14, 2024
1 check passed
@Kumm-Kai
Copy link
Member

Thanks for your contribution! ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants