Allow configuration of the subnet the LB is placed in #287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
malt3
requested review from
dergeberl,
einfachnuralex,
Kumm-Kai and
timebertt
as code owners
malt3
force-pushed
the
feat/yawollet-in-subnet
branch
from
6212876
to
9984ad6
Compare
|
Thanks for your contribution 🥳 Can you please add a test to check that |
I added tests for the loadbalancermachine controller behavior. Please let me know if there is more testing needed! |
Can you please add one more test for the yawol-cloud-controller. To test that it also works that a subnet can be set via an annotation. |
Kumm-Kai
previously requested changes
Apr 15, 2024
controllers/yawol-controller/loadbalancermachine/loadbalancermachine_controller_test.go
Outdated
Show resolved
Hide resolved
controllers/yawol-controller/loadbalancer/loadbalancer_controller.go
Outdated
Show resolved
Hide resolved
malt3
force-pushed
the
feat/yawollet-in-subnet
branch
from
810433c
to
e406d69
Compare
malt3
force-pushed
the
feat/yawollet-in-subnet
branch
from
e406d69
to
447ed9d
Compare
Kumm-Kai
approved these changes
May 14, 2024
This is an optional parameter that can either be left uninitialized to keep the old behavior or be set as a helm value or per LB.
Kumm-Kai
force-pushed
the
feat/yawollet-in-subnet
branch
from
447ed9d
to
7093b22
Compare
|
Thanks for your contribution! ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an optional parameter that can either be left uninitialized to keep the old behavior or be set as a helm value or per LB.
We at edgeless systems have a use-case for yawol where we need the loadbalancer to be in the same network but a different subnet (cidr) than the kubernetes nodes.
This is a requirement for the network encryption we are using in our clusters.
Basically, we need to enforce that any traffic in the node subnet cidr belongs to a k8s node (and can thus enforce it to be encrypted).
Loadbalancer traffic must therefore be part of a separate subnet.