Allow injecting generic-token-kubeconfig secret name into yawol-cloud-controller #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timebertt
requested review from
dergeberl,
einfachnuralex and
breuerfelix
as code owners
dergeberl
reviewed
Jan 4, 2023
| volumeMounts: | ||
| - mountPath: /var/run/secrets/gardener.cloud/shoot/generic-kubeconfig |
There was a problem hiding this comment.
I would like to remove the settings related to gardener from here.
Because yawol also works without gardener.
There was a problem hiding this comment.
Valid point. In this case, I suggest closing this PR and removing all gardener-related values in a new PR.
The gardener extension should be responsible for injecting all gardener-related values in its controller.
2 tasks
|
I added a issue for that #88 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With gardener v1.59.0+, there is no secret with the name
generic-token-kubeconfigin the shoot control plane anymore (ref gardener/gardener@2d1aa09).It has been replaced by an immutable secret with a suffix that is managed by the secrets manager (ref gardener/gardener#5510).
Extensions need to use the
extensionscontroller.GenericTokenKubeconfigSecretNameFromClusterhelper to retrieve the secret name of the currently activegeneric-token-kubeconfigsecret name.This needs to be injected into the
yawol-cloud-controllerdeployment.Accordingly, this PR changes the chart's structure and values to allow the injection of the secret name.