Skip to content
This repository has been archived by the owner. It is now read-only.

Fixed an internal scroll area that could not scroll when the content was not 100% #80

Merged
merged 2 commits into from Jul 17, 2019
Merged

Fixed an internal scroll area that could not scroll when the content was not 100% #80

merged 2 commits into from Jul 17, 2019

Conversation

cytle
Copy link
Contributor

@cytle cytle commented Jul 12, 2019 •
edited

Move event.preventDefault() into the judgment of shouldPassThroughEvent.

In my case, when the contents of the vue-pull-to component do not reach 100% height, the scroll elements inside cannot scroll.

@cytle
Update vue-pull-to.vue
ea98c35 
Remove event.preventDefault() from touchmove handler
@coveralls
Copy link

coveralls commented Jul 12, 2019 •
edited

Coverage Status

Coverage remained the same at 95.833% when pulling c57e319 on cytle:patch-1 into 8ceeb0a on stackjie:master.

@cytle cytle changed the title Update vue-pull-to.vue Fixed an internal scroll area that could not scroll when the content was not 100% Jul 15, 2019
@stackjie
Copy link
Owner

thx

@stackjie stackjie merged commit 2b4cc10 into stackjie:master Jul 17, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@cytle @coveralls @stackjie