Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Process replace commands in parallel #30

Merged
merged 1 commit into from
Dec 11, 2023
Merged

Process replace commands in parallel #30

merged 1 commit into from
Dec 11, 2023

Conversation

JAORMX
Copy link
Contributor

@JAORMX JAORMX commented Dec 4, 2023

This adds some level of parallelization to the replacer commands for
github actions and containers. Hopefully increasing the processing speed.

This adds some level of parallelization to the replacer commands for
github actions and containers. Hopefully increasing the processing speed.
@JAORMX JAORMX changed the title Process replace commands in parallel WIP: Process replace commands in parallel Dec 4, 2023
rdimitrov
rdimitrov previously approved these changes Dec 4, 2023
@rdimitrov rdimitrov self-requested a review December 4, 2023 22:07
@rdimitrov rdimitrov dismissed their stale review December 4, 2023 22:07

Did not see it was stated as WIP, my bad.

@jhrozek
Copy link
Contributor

jhrozek commented Dec 5, 2023

this is already an improvement, what's missing to make the PR non-WIP?
I can see as an additional step we might want to use a syncMap to store what has been resolved (many workflows will probably use e.g. actions/checkout), but this will already speed things up.

@JAORMX
Copy link
Contributor Author

JAORMX commented Dec 5, 2023

@jhrozek mostly that I didn't get a chance to test it. If you did test it already I'd be OK with removing the WIP tag.

@jhrozek
Copy link
Contributor

jhrozek commented Dec 5, 2023 via email

@JAORMX JAORMX changed the title WIP: Process replace commands in parallel Process replace commands in parallel Dec 11, 2023
@JAORMX
Copy link
Contributor Author

JAORMX commented Dec 11, 2023

I tested this and it seems to work fine.

@JAORMX JAORMX requested a review from jhrozek December 11, 2023 13:07
@JAORMX
Copy link
Contributor Author

JAORMX commented Dec 11, 2023

this is already an improvement, what's missing to make the PR non-WIP? I can see as an additional step we might want to use a syncMap to store what has been resolved (many workflows will probably use e.g. actions/checkout), but this will already speed things up.

I can do this in a subsequent PR.

@JAORMX JAORMX merged commit 16e9d20 into main Dec 11, 2023
5 checks passed
@JAORMX JAORMX deleted the replace-parallel branch December 11, 2023 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants