Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix flaky test #38

Merged
merged 2 commits into from
Dec 12, 2023
Merged

Fix flaky test #38

merged 2 commits into from
Dec 12, 2023

Conversation

JAORMX
Copy link
Contributor

@JAORMX JAORMX commented Dec 12, 2023 •
edited

This replaces the require for assert to ease debugging, then it uses a more esoteric domain
for the test.

Closes #37

@JAORMX JAORMX changed the title Replace require for assert in container tests Fix flaky test Dec 12, 2023
@JAORMX JAORMX merged commit bb4bdfa into main Dec 12, 2023
7 checks passed
@JAORMX JAORMX deleted the fix-tests branch December 12, 2023 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhrozek jhrozek jhrozek approved these changes

@rdimitrov rdimitrov Awaiting requested review from rdimitrov

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TestGetDigest/unexistent_container_in_unexistent_registry is flaky
2 participants
@JAORMX @jhrozek