Allow excluding just the action name #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JAORMX
previously approved these changes
Dec 19, 2023
jhrozek
force-pushed
the
exclude_basename
branch
from
9add901
to
889261e
Compare
|
@JAORMX sorry but can you re-approve? There was a copy-paste bug in the tests, nothing else had changed. |
JAORMX
reviewed
Dec 19, 2023
| if shouldExclude(cfg, v.Value, act) { | ||
| continue | ||
| } | ||
|
|
There was a problem hiding this comment.
Actually, after giving it some thought... what about having two exclude checks? One for the raw value + tag and another one for just the action name?
that would make the shouldExclude code simpler, but also improve performance (we don't do parsing if the action was already excluded).
There was a problem hiding this comment.
ha, I didn't think about it!
Frizbee allowed to exclude the whole action name including the tag e.g. `actions/checkout@v4`. But this is not user-friendly for cases where the exclude would be upgraded over time as the exclude would have to be kept in sync. Let's also support the case where the exclude is just in the form of `owner/action_name`.
jhrozek
force-pushed
the
exclude_basename
branch
from
889261e
to
aa48c1a
Compare
JAORMX
approved these changes
Dec 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Frizbee allowed to exclude the whole action name including the tag e.g.
actions/checkout@v4. But this is not user-friendly for cases where the exclude would be upgraded over time as the exclude would have to be kept in sync.Let's also support the case where the exclude is just in the form of
owner/action_name.