Validate the Auth URL (#3787)

We should check and validate me thinks! Signed-off-by: Luke Hinds <luke@stacklok.com>
stacklok · Jul 4, 2024 · d521faa · d521faa
1 parent 3f9c382
commit d521faa
Showing 1 changed file with 4 additions and 0 deletions.
diff --git a/internal/controlplane/handlers_oauth.go b/internal/controlplane/handlers_oauth.go
@@ -172,6 +172,10 @@ func (s *Server) GetAuthorizationURL(ctx context.Context,
 			return nil, status.Errorf(codes.Internal, "error getting GitHub App config: %s", err)
 		}
 		authorizationURL = fmt.Sprintf("%s/apps/%v/installations/new?state=%v", githubURL, gitHubAppConfig.AppName, state)
+		_, err := url.Parse(authorizationURL)
+		if err != nil {
+			return nil, status.Errorf(codes.Internal, "error parsing URL: %s", err)
+		}
 	} else if slices.Contains(providerDef.AuthorizationFlows, db.AuthorizationFlowOauth2AuthorizationCodeFlow) {
 		authorizationURL = oauthConfig.AuthCodeURL(state, oauth2.AccessTypeOffline)
 	}