Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use random salt per key #3316

Closed
dmjb opened this issue May 13, 2024 · 1 comment
Closed

Use random salt per key #3316

dmjb opened this issue May 13, 2024 · 1 comment
Assignees
@dmjb
Labels
user-story

Comments

@dmjb
Copy link
Member

dmjb commented May 13, 2024

Please describe the enhancement

See design doc

Solution Proposal

Add code which generates salt per secret and stores in the DB.

Describe alternatives you've considered

No response

Additional context

No response

Acceptance Criteria

No response
@dmjb dmjb self-assigned this May 17, 2024
dmjb added a commit that referenced this issue May 17, 2024
@dmjb
Generate random salt per key.
c39a5d3 
Fixes #3316

This PR should not be merged until the changes in #3351 have been rolled
out into production.

Generate a random 16-byte salt for each secret we encrypt, and add some
testing around it.
dmjb added a commit that referenced this issue May 17, 2024
@dmjb
Generate random salt per key.
a609fa9 
Fixes #3316

This PR should not be merged until the changes in #3351 have been rolled
out into production.

Generate a random 16-byte salt for each secret we encrypt, and add some
testing around it.
@dmjb dmjb mentioned this issue May 17, 2024
Merged
10 tasks
dmjb added a commit that referenced this issue May 17, 2024
@dmjb
Generate random salt per key.
feb7c2e 
Fixes #3316

This PR should not be merged until the changes in #3351 have been rolled
out into production.

Generate a random 16-byte salt for each secret we encrypt, and add some
testing around it.
dmjb added a commit that referenced this issue May 17, 2024
@dmjb
Generate random salt per key.
e1906fb 
Fixes #3316

This PR should not be merged until the changes in #3351 have been rolled
out into production.

Generate a random 16-byte salt for each secret we encrypt, and add some
testing around it.
@dmjb dmjb closed this as completed May 17, 2024
@dmjb dmjb reopened this May 17, 2024
@dmjb
Copy link
Member Author

dmjb commented May 17, 2024

Not doing this as a separate task - it will be solved as part of #3317

@dmjb dmjb closed this as not planned Won't fix, can't repro, duplicate, stale May 17, 2024
dmjb added a commit that referenced this issue May 20, 2024
@dmjb
Generate random salt per key.
23e2415 
Fixes #3316

This PR should not be merged until the changes in #3351 have been rolled
out into production.

Generate a random 16-byte salt for each secret we encrypt, and add some
testing around it.
dmjb added a commit that referenced this issue May 20, 2024
@dmjb
Generate random salt per key.
63d1b21 
Fixes #3316

This PR should not be merged until the changes in #3351 have been rolled
out into production.

Generate a random 16-byte salt for each secret we encrypt, and add some
testing around it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dmjb dmjb

Labels
user-story
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dmjb