Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't pre-create github provider on registration #4213

Closed
eleftherias opened this issue Aug 20, 2024 · 1 comment
Closed

Don't pre-create github provider on registration #4213

eleftherias opened this issue Aug 20, 2024 · 1 comment

Comments

@eleftherias
Copy link
Member

Note: This is not about removing or changing the legacy OAuth GitHub provider.

When a user registers for Minder, currently a provider gets pre-created for them.
After running minder auth login for the first time, if they run minder provider list they will see the following:

+--------+--------------------------------------+---------+--------------------------------+
|  NAME  |               PROJECT                | VERSION |           IMPLEMENTS           |
+--------+--------------------------------------+---------+--------------------------------+
| github | 9f2ebd65-0e49-4ed1-968f-f661b9987261 | v1      | github, git, rest, repo-lister |
+--------+--------------------------------------+---------+--------------------------------+

This is confusing, because the user has not enrolled any providers, yet they see one already exists.
Furthermore, this provider cannot be used, since it does not have a valid credential associated with it. It is left over from an earlier version of Minder where the provider needed to pre-exist before it could be enrolled.

We should remove that built-in provider, so that when a user registers for the first time, they do not have any providers pre-created.

Enrolling the github provider should continue to work as before.

@eleftherias
Copy link
Member Author

Closed via #4367

@eleftherias eleftherias removed their assignment Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant