Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't retry all handler errors #1281

Merged
merged 1 commit into from
Oct 25, 2023
Merged

Don't retry all handler errors #1281

merged 1 commit into from
Oct 25, 2023

Conversation

jhrozek
Copy link
Contributor

@jhrozek jhrozek commented Oct 24, 2023

Our retry logic seems to have been reversed. We should be only retrying
errors that are marked as retriable by returning an error to the event
handler. Otherwise, let's just log an error and be done with the event.

Fixes: #1259

Our retry logic seems to have been reversed. We should be only retrying
errors that are marked as retriable by returning an error to the event
handler. Otherwise, let's just log an error and be done with the event.

Fixes: #1259
@JAORMX JAORMX merged commit 3927972 into stacklok:main Oct 25, 2023
12 checks passed
@JAORMX JAORMX deleted the retriable branch October 25, 2023 04:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: Mediator's message retry logic seems backwards
2 participants