Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix go.mod for tools and update go to 1.21 #1322

Merged
merged 3 commits into from
Oct 30, 2023
Merged

Conversation

rdimitrov
Copy link
Member

The following PR updates the go.mod dependencies for tools fixing the make bootstrap failure from #1317

Closes #1317

@rdimitrov rdimitrov self-assigned this Oct 30, 2023
@rdimitrov rdimitrov changed the title Fix go.mod for tools Fix go.mod for tools and update go to 1.21 Oct 30, 2023
Copy link
Member

@eleftherias eleftherias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The files in internal/db/ are out of date (it's only the comment that includes the version that needs to change).
If you run make bootstrap and then make sqlc you'll see the changes locally.

@rdimitrov
Copy link
Member Author

The files in internal/db/ are out of date (it's only the comment that includes the version that needs to change). If you run make bootstrap and then make sqlc you'll see the changes locally.

Yeah, I just did that, I realised I forgot to generate.

eleftherias
eleftherias previously approved these changes Oct 30, 2023
Signed-off-by: Radoslav Dimitrov <radoslav@stacklok.com>
Signed-off-by: Radoslav Dimitrov <radoslav@stacklok.com>
Signed-off-by: Radoslav Dimitrov <radoslav@stacklok.com>
@rdimitrov rdimitrov merged commit c8c340c into stacklok:main Oct 30, 2023
12 checks passed
@rdimitrov rdimitrov deleted the go-tidy branch October 30, 2023 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants