Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix vulncheck's repo cache to be concurrency-friendly #1351

Merged
merged 2 commits into from
Oct 31, 2023
Merged

Conversation

JAORMX
Copy link
Contributor

@JAORMX JAORMX commented Oct 31, 2023

This uses xsync's Map instead of a bare map. This way we can avoid the concurrency issues.

This uses xsync's Map instead of a bare map. This way we can avoid the concurrency issues.
Copy link
Member

@eleftherias eleftherias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commit message shouldn't start with fix:

@JAORMX
Copy link
Contributor Author

JAORMX commented Oct 31, 2023

Commit message shouldn't start with fix:

Got a link of acceptable words to use?

@JAORMX JAORMX changed the title fix: fix vulncheck's repo cache to be concurrency-friendly Fix vulncheck's repo cache to be concurrency-friendly Oct 31, 2023
@JAORMX
Copy link
Contributor Author

JAORMX commented Oct 31, 2023

I've removed the fix: word from the PR title.

@JAORMX JAORMX merged commit d49d57e into main Oct 31, 2023
12 checks passed
@JAORMX JAORMX deleted the fix-repo-cache branch October 31, 2023 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants