Setup go before building with ko and update go.mod #1362
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rdimitrov
force-pushed
the
bump-watermill
branch
from
fd45dd1
to
4b42c1b
Compare
rdimitrov
changed the title
jhrozek
previously approved these changes
Nov 1, 2023
JAORMX
previously approved these changes
Nov 1, 2023
Signed-off-by: Radoslav Dimitrov <radoslav@stacklok.com>
Signed-off-by: Radoslav Dimitrov <radoslav@stacklok.com>
rdimitrov
force-pushed
the
bump-watermill
branch
from
4b42c1b
to
ec48105
Compare
JAORMX
approved these changes
Nov 1, 2023
JAORMX
added a commit
that referenced
this pull request
Nov 1, 2023
#1362 introduced the `setup-go` command in the befinning of a lot of our jobs. This was missed in the helm chart publish job.
rdimitrov
pushed a commit
that referenced
this pull request
Nov 1, 2023
This was referenced Nov 2, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apparently we have to setup go before building with ko since it started failing after we bumped our go version to 1.21.
Closes #1326