Extend the PR vuln check docs with commit status #1409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhrozek
commented
Nov 2, 2023
| is to use the `commit-status` action instead of `review` where Minder will set | ||
| the commit status to `failure` if the PR introduces a new vulnerability which can | ||
| then be used to block the PR. This requires an additional step though, where | ||
| the repo needs to require the `minder.stacklok.dev/pr-vulncheck` status to |
There was a problem hiding this comment.
I totally forgot about this, but since we have the branch protection remediations now, we could add a branch protection rule that ensures that certain commit statuses pass before merging and we could have one with this status, so that users don't have to enable anything manually.
Thoughts?
There was a problem hiding this comment.
It would be a nice touch 👍 Let's open an issue so we don't forget 👍
JAORMX
approved these changes
Nov 2, 2023
jhrozek
force-pushed
the
docs_pr_block_commit_status
branch
from
de399f3
to
b873ae6
Compare
rdimitrov
approved these changes
Nov 2, 2023
| is to use the `commit-status` action instead of `review` where Minder will set | ||
| the commit status to `failure` if the PR introduces a new vulnerability which can | ||
| then be used to block the PR. This requires an additional step though, where | ||
| the repo needs to require the `minder.stacklok.dev/pr-vulncheck` status to |
There was a problem hiding this comment.
It would be a nice touch 👍 Let's open an issue so we don't forget 👍
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should also mention this feature since we expect that many users will self-enroll