Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace unpinned actions with pinned action #1945

Closed

Conversation

stacklokbot
Copy link
Member

This is a Minder automated pull request.

This pull request replaces references to actions by tag to references to actions by SHA.

Verifies that any actions use pinned tags
Pinning an action to a full length commit SHA is currently the only way to use
an action as an immutable release. Pinning to a particular SHA helps mitigate
the risk of a bad actor adding a backdoor to the action's repository, as they
would need to generate a SHA-1 collision for a valid Git object payload.
When selecting a SHA, you should verify it is from the action's repository
and not a repository fork.

For more information, see
https://docs.github.com/en/actions/security-guides/security-hardening-for-github-actions#using-third-party-actions

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Stacklok Bot seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@rdimitrov
Copy link
Member

cc: @dussab

@dussab
Copy link
Member

dussab commented Dec 15, 2023

The issue might be related to the fact the CLA Tool cannot determine the user account associated with the commit. The Stacklok bot commit seems to be missing the email address associated with the Stacklokbot commit. Here is the commit for reference: https://github.com/stacklok/minder/commit/a25953167b4774c52a930645714f97cf9c68be4c.patch @jhrozek is investigating this further.

@stacklokbot stacklokbot force-pushed the minder_replace_unpinned_actions_with_pinned_action branch 27 times, most recently from 8b951bf to 67671a9 Compare December 18, 2023 08:30
@stacklokbot stacklokbot force-pushed the minder_replace_unpinned_actions_with_pinned_action branch 9 times, most recently from 9d6d5d0 to 8594c39 Compare December 18, 2023 08:31
@stacklokbot stacklokbot force-pushed the minder_replace_unpinned_actions_with_pinned_action branch from 8594c39 to b1558d1 Compare December 18, 2023 08:32
@JAORMX JAORMX closed this Dec 19, 2023
@JAORMX JAORMX deleted the minder_replace_unpinned_actions_with_pinned_action branch December 19, 2023 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants