Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a unit test for switch of a profile state to pending #2977

Merged
merged 1 commit into from
Apr 6, 2024

Conversation

jhrozek
Copy link
Contributor

@jhrozek jhrozek commented Apr 6, 2024

Summary

We recently suspected that one of our stored procedures is not behaving
as it should. This turned out to be false, but during debugging of the
stored procedure I already wrote a unit test for the behaviour that was
not working at the moment.

It makes sense to submit it in case we regress in the future.

Change Type

Mark the type of change your PR introduces:

  • Bug fix (resolves an issue without affecting existing features)
  • Feature (adds new functionality without breaking changes)
  • Breaking change (may impact existing functionalities or require documentation updates)
  • Documentation (updates or additions to documentation)
  • Refactoring or test improvements (no bug fixes or new functionality)

Testing

run the test

Review Checklist:

  • Reviewed my own code for quality and clarity.
  • Added comments to complex or tricky code sections.
  • Updated any affected documentation.
  • Included tests that validate the fix or feature.
  • Checked that related changes are merged.

We recently suspected that one of our stored procedures is not behaving
as it should. This turned out to be false, but during debugging of the
stored procedure I already wrote a unit test for the behaviour that was
not working at the moment.

It makes sense to submit it in case we regress in the future.
@jhrozek jhrozek requested a review from a team as a code owner April 6, 2024 18:29
@coveralls
Copy link

Coverage Status

coverage: 48.335%. remained the same
when pulling 0e034f9 on jhrozek:stored_procedure_test_for_pending
into deefb74 on stacklok:main.

@jhrozek jhrozek merged commit c63fe17 into stacklok:main Apr 6, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants