-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove hardcoded dependency between artifacts and projects #2991
Conversation
96b9d9f
to
0f578bd
Compare
9eba776
to
196cf10
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving. It's unfortunate that we need to add the provider name to the artifacts table, but it's a temporary approach so I think it's fine for now.
ada499c
to
5d72973
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this works for me!
This makes repos nullable in artifacts. As of today, this is not really a case that actually happens... so this should effectively be a no-op. However, the idea is that soon we'll start getting artifacts that that come from other providers that are not the same as the repository they are linked to. Signed-off-by: Juan Antonio Osorio <ozz@stacklok.com>
Co-authored-by: Jakub Hrozek <jakub@stacklok.com>
Co-authored-by: Jakub Hrozek <jakub@stacklok.com>
Signed-off-by: Juan Antonio Osorio <ozz@stacklok.com>
Signed-off-by: Juan Antonio Osorio <ozz@stacklok.com>
5d72973
to
da8ab74
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this works even better for me!
Summary
This makes repos nullable in artifacts. As of today, this is not really
a case that actually happens... so this should effectively be a no-op.
However, the idea is that soon we'll start getting artifacts that that
come from other providers that are not the same as the repository they
are linked to.
Change Type
Mark the type of change your PR introduces:
Testing
Outline how the changes were tested, including steps to reproduce and any relevant configurations.
Attach screenshots if helpful.
Review Checklist: