Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove hardcoded dependency between artifacts and projects #2991

Merged
merged 5 commits into from
Apr 10, 2024

Conversation

JAORMX
Copy link
Contributor

@JAORMX JAORMX commented Apr 8, 2024

Summary

This makes repos nullable in artifacts. As of today, this is not really
a case that actually happens... so this should effectively be a no-op.
However, the idea is that soon we'll start getting artifacts that that
come from other providers that are not the same as the repository they
are linked to.

Change Type

Mark the type of change your PR introduces:

  • Bug fix (resolves an issue without affecting existing features)
  • Feature (adds new functionality without breaking changes)
  • Breaking change (may impact existing functionalities or require documentation updates)
  • Documentation (updates or additions to documentation)
  • Refactoring or test improvements (no bug fixes or new functionality)

Testing

Outline how the changes were tested, including steps to reproduce and any relevant configurations.
Attach screenshots if helpful.

Review Checklist:

  • Reviewed my own code for quality and clarity.
  • Added comments to complex or tricky code sections.
  • Updated any affected documentation.
  • Included tests that validate the fix or feature.
  • Checked that related changes are merged.

@JAORMX JAORMX requested a review from a team as a code owner April 8, 2024 11:06
@JAORMX JAORMX force-pushed the artifacts-projects branch 3 times, most recently from 96b9d9f to 0f578bd Compare April 8, 2024 11:56
@coveralls
Copy link

coveralls commented Apr 8, 2024

Coverage Status

coverage: 48.323% (-0.05%) from 48.373%
when pulling da8ab74 on artifacts-projects
into af5fcf3 on main.

@JAORMX JAORMX force-pushed the artifacts-projects branch 4 times, most recently from 9eba776 to 196cf10 Compare April 9, 2024 08:04
dmjb
dmjb previously approved these changes Apr 9, 2024
Copy link
Member

@dmjb dmjb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving. It's unfortunate that we need to add the provider name to the artifacts table, but it's a temporary approach so I think it's fine for now.

jhrozek
jhrozek previously approved these changes Apr 10, 2024
Copy link
Contributor

@jhrozek jhrozek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this works for me!

JAORMX and others added 5 commits April 10, 2024 10:55
This makes repos nullable in artifacts. As of today, this is not really
a case that actually happens... so this should effectively be a no-op.
However, the idea is that soon we'll start getting artifacts that that
come from other providers that are not the same as the repository they
are linked to.

Signed-off-by: Juan Antonio Osorio <ozz@stacklok.com>
Co-authored-by: Jakub Hrozek <jakub@stacklok.com>
Co-authored-by: Jakub Hrozek <jakub@stacklok.com>
Signed-off-by: Juan Antonio Osorio <ozz@stacklok.com>
Signed-off-by: Juan Antonio Osorio <ozz@stacklok.com>
Copy link
Contributor

@jhrozek jhrozek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this works even better for me!

@JAORMX JAORMX merged commit 5abbaa3 into main Apr 10, 2024
22 checks passed
@JAORMX JAORMX deleted the artifacts-projects branch April 10, 2024 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants