Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Default to github-app in provider enroll #3032

Merged
merged 3 commits into from
Apr 11, 2024
Merged

Default to github-app in provider enroll #3032

merged 3 commits into from
Apr 11, 2024

Commits on Apr 11, 2024

  1. Default to github-app in provider enroll 

    Fixes #2898

Some additional changes have been made as well:

1) Make the flag to specify the class of provider specific to the enroll
   command. The existing top-level provider flag is left intact, but
   marked as deprecated.
2) The confirmation box is only shown for the legacy Github app workflow
   as requested in the ticket.
3) The timeout duration is listed in the CLI output when the browser is
   opened.
4) Small changes to message verbiage here and there.
    @dmjb
    dmjb committed Apr 11, 2024
    Configuration menu
    Copy the full SHA
    ba4e677 View commit details
    Browse the repository at this point in the history

  2. address feedback from @eleftherias

    @dmjb
    dmjb committed Apr 11, 2024
    Configuration menu
    Copy the full SHA
    f70d601 View commit details
    Browse the repository at this point in the history

  3. fix typo

    @dmjb
    dmjb committed Apr 11, 2024
    Configuration menu
    Copy the full SHA
    7ed2b14 View commit details
    Browse the repository at this point in the history