Support Logging GitHub requests #3054
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes a bug where the github app key was being mounted as a directory when bringing up docker compose Signed-off-by: Adolfo García Veytia (Puerco) <puerco@stacklok.com>
JAORMX
reviewed
Apr 12, 2024
internal/providers/github/app/app.go
Outdated
| transport = &loghttp.Transport{ | ||
| Transport: transport, | ||
| LogRequest: func(req *http.Request) { | ||
| zerolog.Ctx(context.Background()).Info(). |
There was a problem hiding this comment.
Let's make this Trace not Info
There was a problem hiding this comment.
Let's use the request's context with req.Context()
This commit introduces a change to log all github requests when setting the MINDER_LOG_GITHUB_REQUESTS env var Signed-off-by: Adolfo García Veytia (Puerco) <puerco@stacklok.com>
Log all github requests by default when running in docker compose Signed-off-by: Adolfo García Veytia (Puerco) <puerco@stacklok.com>
Signed-off-by: Adolfo García Veytia (puerco) <puerco@stacklok.com>
JAORMX
approved these changes
Apr 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This commit adds a change to support wrapping the github client in a logger to log all requests minder send to the GitrHub API.
When setting the
$MINDER_LOG_GITHUB_REQUESTSenv var, minder will start logging all requests and responses:The docker compose configuration now sets the variable to log everything when developing locally.
Bonus: I also fixed a bug in the docker conf that was mounting the github app private key path as a directory.
Change Type
Testing
Sample output:
Review Checklist: