Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add no-op handler for GitHub Marketplace events #3064

Merged
merged 1 commit into from
Apr 12, 2024

Conversation

eleftherias
Copy link
Member

Summary

In order to list our GitHub App on the GitHub Marketplace, we need a webhook handler for Marketplace events.
This is a no-op handler because we don't need to react to marketplace events (e.g. purchases).

Fixes #3063

Change Type

Mark the type of change your PR introduces:

  • Bug fix (resolves an issue without affecting existing features)
  • Feature (adds new functionality without breaking changes)
  • Breaking change (may impact existing functionalities or require documentation updates)
  • Documentation (updates or additions to documentation)
  • Refactoring or test improvements (no bug fixes or new functionality)

Testing

Outline how the changes were tested, including steps to reproduce and any relevant configurations.
Attach screenshots if helpful.

Review Checklist:

  • Reviewed my own code for quality and clarity.
  • Added comments to complex or tricky code sections.
  • Updated any affected documentation.
  • Included tests that validate the fix or feature.
  • Checked that related changes are merged.

@eleftherias eleftherias requested a review from a team as a code owner April 12, 2024 07:56
@eleftherias eleftherias merged commit 612ad23 into stacklok:main Apr 12, 2024
20 checks passed
@eleftherias eleftherias deleted the 3063-marketplace-webhook branch April 12, 2024 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add webhook handler for GitHub Marketplace events
2 participants