Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Remove impossible condition #3213

Merged
merged 2 commits into from
May 1, 2024
Merged

Bug: Remove impossible condition #3213

merged 2 commits into from
May 1, 2024

Conversation

puerco
Copy link
Member

@puerco puerco commented May 1, 2024

Summary

This is a minor update that removes a useless condition from the code.

Change Type

Mark the type of change your PR introduces:

  • Bug fix (resolves an issue without affecting existing features)
  • Feature (adds new functionality without breaking changes)
  • Breaking change (may impact existing functionalities or require documentation updates)
  • Documentation (updates or additions to documentation)
  • Refactoring or test improvements (no bug fixes or new functionality)

Testing

Outline how the changes were tested, including steps to reproduce and any relevant configurations.
Attach screenshots if helpful.

Review Checklist:

  • Reviewed my own code for quality and clarity.
  • Added comments to complex or tricky code sections.
  • Updated any affected documentation.
  • Included tests that validate the fix or feature.
  • Checked that related changes are merged.

This is a minor update that removes a useless condition from the code.

Signed-off-by: Adolfo García Veytia (puerco) <puerco@stacklok.com>
@puerco puerco added the bug Something isn't working label May 1, 2024
@puerco puerco requested a review from a team as a code owner May 1, 2024 04:50
@coveralls
Copy link

coveralls commented May 1, 2024

Coverage Status

coverage: 50.526% (+0.01%) from 50.514%
when pulling be8a8e2 on puerco:condition
into 7c50e65 on stacklok:main.

@puerco
Copy link
Member Author

puerco commented May 1, 2024

The unit tests had failed due to an unrelated race.
image

@puerco puerco merged commit 5cfed9f into stacklok:main May 1, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants