Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dependency review #3314

Merged
merged 2 commits into from
May 13, 2024
Merged

Add dependency review #3314

merged 2 commits into from
May 13, 2024

Conversation

therealnb
Copy link
Contributor

@therealnb therealnb commented May 13, 2024

Summary

Add dependency review. Just a test for now with a local copy.

Fixes https://github.com/stacklok/epics/issues/278

Up to you if you want to include this, the dependency review is documented herehttps://github.com/actions/dependency-review-action/tree/main.

Change Type

Mark the type of change your PR introduces:

  • Bug fix (resolves an issue without affecting existing features)
  • Feature (adds new functionality without breaking changes)
  • Breaking change (may impact existing functionalities or require documentation updates)
  • Documentation (updates or additions to documentation)
  • Refactoring or test improvements (no bug fixes or new functionality)

Testing

Look at the checks

Review Checklist:

  • Reviewed my own code for quality and clarity.
  • Added comments to complex or tricky code sections.
  • Updated any affected documentation.
  • Included tests that validate the fix or feature.
  • Checked that related changes are merged.

Signed-off-by: nigel brown <nigel@stacklok.com>
@therealnb therealnb requested a review from a team as a code owner May 13, 2024 08:47
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link
Member

@stacklokbot stacklokbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ No Invisible Unicode Characters Detected.

@coveralls
Copy link

coveralls commented May 13, 2024

Coverage Status

coverage: 49.292% (-0.005%) from 49.297%
when pulling cef9476 on add_dependency_review
into b575d92 on main.

Copy link
Member

@stacklokbot stacklokbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ No Invisible Unicode Characters Detected.

Copy link
Member

@stacklokbot stacklokbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ No Mixed Scripts Detected.

@therealnb therealnb merged commit 5183c10 into main May 13, 2024
21 of 22 checks passed
@therealnb therealnb deleted the add_dependency_review branch May 13, 2024 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants