Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decouple Action Engine from Rule Type Engine #3599

Merged
merged 4 commits into from
Jun 14, 2024
Merged

Conversation

dmjb
Copy link
Member

@dmjb dmjb commented Jun 13, 2024

Relates to #3556

This allows the rule type engine to be reused across multiple profiles. This simplifies a change in an upcoming PR to cache rule types during profile evaluation.

Summary

Provide a brief overview of the changes and the issue being addressed.
Explain the rationale and any background necessary for understanding the changes.
List dependencies required by this change, if any.

Fixes #(related issue)

Change Type

Mark the type of change your PR introduces:

  • Bug fix (resolves an issue without affecting existing features)
  • Feature (adds new functionality without breaking changes)
  • Breaking change (may impact existing functionalities or require documentation updates)
  • Documentation (updates or additions to documentation)
  • Refactoring or test improvements (no bug fixes or new functionality)

Testing

Outline how the changes were tested, including steps to reproduce and any relevant configurations.
Attach screenshots if helpful.

Review Checklist:

  • Reviewed my own code for quality and clarity.
  • Added comments to complex or tricky code sections.
  • Updated any affected documentation.
  • Included tests that validate the fix or feature.
  • Checked that related changes are merged.

@dmjb dmjb requested a review from a team as a code owner June 13, 2024 13:57
dmjb added 3 commits June 13, 2024 15:06
Relates to #3556

This allows the rule type engine to be reused across multiple profiles.
This simplifies a change in an upcoming PR to cache rule types during
profile evaluation.
@dmjb dmjb force-pushed the remediation-status-eval-params branch from fc354bd to 9a88e2a Compare June 13, 2024 14:07
@coveralls
Copy link

Coverage Status

coverage: 53.333% (-0.03%) from 53.367%
when pulling bcad399 on remediation-status-eval-params
into 5d1bd36 on main.

Copy link
Member

@puerco puerco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one Don, thanks!

@dmjb dmjb merged commit 5d33ee6 into main Jun 14, 2024
21 checks passed
@dmjb dmjb deleted the remediation-status-eval-params branch June 14, 2024 14:21
jhrozek added a commit to jhrozek/minder that referenced this pull request Jun 17, 2024
This commit caused the actions to always be skipped.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants