Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow users to change their profile info and password #983

Merged
merged 1 commit into from
Sep 19, 2023
Merged

Allow users to change their profile info and password #983

merged 1 commit into from
Sep 19, 2023

Conversation

evankanderson
Copy link
Member

Discovered during customer empathy session.

JAORMX
JAORMX approved these changes Sep 19, 2023
View reviewed changes
Copy link
Contributor

@JAORMX JAORMX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops!

@evankanderson
Copy link
Member Author

Prior to #894, IsRequestAuthorized defaulted to return true if the method wasn't found in resourceAuthorizations: https://github.com/stacklok/mediator/blob/9248811c3de779edc1786048c0e9ad08d3ef42fd/pkg/controlplane/handlers_authz.go#L448

After that change, IsRequestAuthorized defaults to false unless a scope is associated with the RPC.

@evankanderson evankanderson merged commit 2e90ef4 into stacklok:main Sep 19, 2023
12 checks passed
@JAORMX JAORMX deleted the self-change-password branch September 19, 2023 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JAORMX JAORMX JAORMX approved these changes

@eleftherias eleftherias eleftherias approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@evankanderson @JAORMX @eleftherias