Change build settings for 'fast' module to link against cairo library #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marssaxman
force-pushed
the
dlink-cairo
branch
from
9f70d86
to
fdd8eb1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The 'fast' module did not work on my system out of the box, because it could not resolve the external cairo_foo symbols; it compiled, and generated the appropriate extern refs, but did not have a dependency on libcairo.so, and thus the loader would fail to resolve them. I have updated the makefile using pkg-config to generate cflags and linker flags, and now I am able to run the 'fast' module for waveform rendering. This change also allows fast.pyx to make use of libcairo's own header file instead of having to duplicate the definitions in fast.h.
This branch includes the 'cython' vs 'cython2' change, but I'm happy to revise it not to depend on that prior commit, if you'd prefer.