Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kube-linter go module versioning is broken #494

Closed
pmalek opened this issue Feb 16, 2023 · 0 comments · Fixed by #497
Closed

kube-linter go module versioning is broken #494

pmalek opened this issue Feb 16, 2023 · 0 comments · Fixed by #497

Comments

@pmalek
Copy link

pmalek commented Feb 16, 2023

Problem statement

It seems that kube-linter is not adhering to semver versioning w.r.t having a v prefix in tag names, as mentioned e.g. in https://go.dev/blog/publishing-go-modules#semantic-versions-and-modules.

This causes go toolchain to not detect newer versions than v0.4.0 which by accident (?) had v prefix.

How to reproduce

To reproduce this it's enough to:

$ go mod init randomname
$ go get golang.stackrox.io/kube-linter@latest
go: added golang.stackrox.io/kube-linter v0.4.0

One thing that might be considered is changing https://github.com/stackrox/kube-linter/blob/main/.github/workflows/build.yaml#L10 to "v*" or something more specific like:

      - 'v[0-9]+.[0-9]+.[0-9]+'
      - 'v[0-9]+.[0-9]+.[0-9]+-alpha.[0-9]+'
      - 'v[0-9]+.[0-9]+.[0-9]+-beta.[0-9]+'
      - 'v[0-9]+.[0-9]+.[0-9]+-rc.[0-9]+'
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant