Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add v prefix to release-drafter's tag template #497

Merged
merged 1 commit into from
Feb 22, 2023
Merged

fix: add v prefix to release-drafter's tag template #497

merged 1 commit into from
Feb 22, 2023

Conversation

czeslavo
Copy link
Contributor

@czeslavo czeslavo commented Feb 21, 2023 •
edited
Loading

In order to make tags created by the release-drafter compatible with Go modules, tags have to begin with v prefix.

It should fix #494.

@czeslavo
fix: add v prefix to release-drafter's tag template
51888fc 
In order to make tags created by the release-drafter compatible with Go modules, 
tags have to begin with `v` prefix.
@janisz
Copy link
Collaborator

janisz commented Feb 22, 2023

I don't know what was the reason for dropping v from tag. But I think it should not break anything.

@janisz janisz requested a review from dhaus67 February 22, 2023 11:41
@janisz
Copy link
Collaborator

janisz commented Feb 22, 2023

Maybe we should manually double tag all previous releases with v prefixed tags.

dhaus67
dhaus67 approved these changes Feb 22, 2023
View reviewed changes
Copy link
Contributor

@dhaus67 dhaus67 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. One thing to note is that the version tag will now change for users of the kube-linter action going forward, but as long as we keep the previously tagged version, I don't see any issue with making the change 👍

@janisz janisz merged commit e319b09 into stackrox:main Feb 22, 2023
@janisz janisz mentioned this pull request Apr 11, 2023
Closed
@janisz janisz mentioned this pull request Jul 17, 2023
Open
abrad3 pushed a commit to abrad3/kube-linter that referenced this pull request Sep 28, 2023
@czeslavo @abrad3
fix: add v prefix to release-drafter's tag template (stackrox#497)
2d4586b 
In order to make tags created by the release-drafter compatible with Go modules, 
tags have to begin with `v` prefix.
@janisz janisz mentioned this pull request Jan 10, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@janisz janisz janisz approved these changes

@dhaus67 dhaus67 dhaus67 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

kube-linter go module versioning is broken
3 participants
@czeslavo @janisz @dhaus67