Change unset-cpu-requirements check #694
Labels
Comments
janisz
added
enhancement
bgalek
added a commit
to bgalek/kube-linter
that referenced
this issue
Feb 26, 2024
bgalek
added a commit
to bgalek/kube-linter
that referenced
this issue
Feb 26, 2024
bgalek
added a commit
to bgalek/kube-linter
that referenced
this issue
Feb 26, 2024
bgalek
added a commit
to bgalek/kube-linter
that referenced
this issue
Feb 26, 2024
bgalek
added a commit
to bgalek/kube-linter
that referenced
this issue
Feb 26, 2024
bgalek
added a commit
to bgalek/kube-linter
that referenced
this issue
Feb 27, 2024
bgalek
added a commit
to bgalek/kube-linter
that referenced
this issue
Feb 27, 2024
bgalek
added a commit
to bgalek/kube-linter
that referenced
this issue
Feb 27, 2024
bgalek
added a commit
to bgalek/kube-linter
that referenced
this issue
Feb 27, 2024
bgalek
added a commit
to bgalek/kube-linter
that referenced
this issue
Feb 27, 2024
bgalek
added a commit
to bgalek/kube-linter
that referenced
this issue
Feb 27, 2024
bgalek
added a commit
to bgalek/kube-linter
that referenced
this issue
Feb 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Currently the
unset-cpu-requirementsrequires requests and limits while in general having only requests should be sufficient. Requests are essential for scheduling, and since omitting limits would simply allow the application to utilize a slightly higher amount of CPU if necessary, we should no longer recommend specifying both requests and limits.The change should happen in check definition
kube-linter/pkg/builtinchecks/yamls/unset-cpu-requirements.yaml
Line 11 in e68f7d1
As well in related tests:
@test "unset-cpu-requirements" {
kube-linter/e2etests/bats-tests.sh
Line 895 in e68f7d1
The text was updated successfully, but these errors were encountered: