Add support to check dnsConfig options #358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trumant
reviewed
Jun 8, 2022
| @@ -0,0 +1,12 @@ | |||
| name: "dnsconfig-options" | |||
There was a problem hiding this comment.
Is this implementation too ndots specific? In other words, does the solution as written provide a mechanism to check other aspects of dnsConfig like nameservers and searches?
There was a problem hiding this comment.
Current implementation supports matching in options field, such as ndots, timeout, attempts, etc. A full list here under options section. nameservers and searches are at the same level as options, so not supported currently.
mdb
reviewed
Jun 8, 2022
mdb
reviewed
Jun 8, 2022
Co-authored-by: Travis Truman <trumant@gmail.com>
Co-authored-by: Mike Ball <mikedball@gmail.com>
Co-authored-by: Mike Ball <mikedball@gmail.com>
janisz
approved these changes
Jun 14, 2022
viswajithiii
approved these changes
Jun 16, 2022
|
Hi @viswajithiii @janisz , any chance for merging this pr? Thanks! |
abrad3
pushed a commit
to abrad3/kube-linter
that referenced
this pull request
Sep 28, 2023
Co-authored-by: Travis Truman <trumant@gmail.com> Co-authored-by: Mike Ball <mikedball@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is for feature request #354
Add support to check dnsConfig options.
Thanks @trumant for the initial discussion.