Set permissions to binaries before uploading them. #371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhaus67
force-pushed
the
binaries-executable
branch
from
0ec7e12
to
32b14bc
Compare
viswajithiii
approved these changes
Jul 6, 2022
abrad3
pushed a commit
to abrad3/kube-linter
that referenced
this pull request
Sep 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There is an issue currently with the release of kube-linter, specifically the permissions on the binaries.
When uploading them, they are not set to be executable. However, the kube-linter-github-action expects them to be.
While we could fix the action to ensure the binary is executable as well, the permission was set in the past, so we should ensure this is the case once more.