Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added t.Run() to use test name in unit test #374

Merged
merged 1 commit into from
Jul 29, 2022

Conversation

Ankit152
Copy link
Contributor

Signed-off-by: Ankit Kurmi ankitkurmi152@gmail.com

Description

Added t.Run() to use test name for the unit test present in pkg/common/command/template_test.go.

Signed-off-by: Ankit152 <ankitkurmi152@gmail.com>
@Ankit152 Ankit152 requested a review from janisz as a code owner July 14, 2022 06:23
Copy link
Contributor

@dhaus67 dhaus67 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution, LGTM!

@dhaus67 dhaus67 merged commit ad574c5 into stackrox:main Jul 29, 2022
@Ankit152
Copy link
Contributor Author

Thank you for merging the PR! 🙂

@Ankit152 Ankit152 deleted the uni-test-refactor branch July 29, 2022 06:41
abrad3 pushed a commit to abrad3/kube-linter that referenced this pull request Sep 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants