Create new check for liveness port #661
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janisz
requested changes
Nov 21, 2023
charlesoconor
force-pushed
the
add-check-for-ports-in-liveness-prob
branch
from
ec54b69
to
7df14b8
Compare
|
Thanks for the review! Have updated with the requested changes. |
|
@janisz, is there anything else you want me to change? Take another look when you have a chance. |
Want to ensure the port is correctly set for liveness probe since it's easy to make a typo when people are doing copy pasta. This will let you know it's failing airier and not have to wait for a failed deployment. Want to do this also for startup and readiness checks. Assume it make sense to have them as other checks and was planning on doing that in a follow up.
charlesoconor
force-pushed
the
add-check-for-ports-in-liveness-prob
branch
from
7df14b8
to
97b2cd9
Compare
janisz
approved these changes
Dec 22, 2023
|
@charlesoconor Thank you. I'm sorry I missed your comment, you can re-request review to speed up the process as I'll see this PR on my https://github.com/pulls board |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Want to ensure the port is correctly set for liveness probe since it's easy to make a typo when people are doing copy pasta. This will let you know it's failing airier and not have to wait for a failed deployment.
Want to do this also for startup and readiness checks. Assume it make sense to have them as other checks and was planning on doing that in a follow up.