Extend liveness-port logic for two new checks around startup and readiness #689
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
readiness Also added a check for the new `grpc` check that has been added in newer versions of k8s.
|
@janisz Sorry to bug you. This PR passed with go 1.21 as the toolchain. Initially, I pushed this up without thinking since it had that installed and I had to run |
Signed-off-by: Tomasz Janiszewski <tomek@redhat.com>
janisz
approved these changes
Jan 12, 2024
|
@charlesoconor I've run |
|
Thank you! Anything I need to change before a merge. |
|
@charlesoconor Thanks! It will be released soon! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also added a check for the new
grpccheck that has been added in newer versions of k8s.