ROX-16643: Set acscs-worker role #162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stehessel
reviewed
Nov 13, 2023
scripts/test-prom-rules.sh
Outdated
| @@ -10,7 +10,7 @@ SCRIPT_DIR="$(cd -- "$(dirname -- "${BASH_SOURCE[0]:-$0}")" &>/dev/null && pwd 2 | |||
|
|
|||
| yq eval '.spec' "${SCRIPT_DIR}"/../resources/prometheus/prometheus-rules.yaml >/tmp/prometheus-rules-test.yaml | |||
| yq eval '.spec' "${SCRIPT_DIR}"/../resources/prometheus/rhacs-recording-rules.yaml >/tmp/recording-rules-test.yaml | |||
| for f in "${SCRIPT_DIR}"/../resources/prometheus/unit_tests/*; do | |||
| for f in "${SCRIPT_DIR}"/../resources/prometheus/unit_tests/WorkerNodes*; do | |||
There was a problem hiding this comment.
Suggested change
| for f in "${SCRIPT_DIR}"/../resources/prometheus/unit_tests/WorkerNodes*; do | |
| for f in "${SCRIPT_DIR}"/../resources/prometheus/unit_tests/*; do |
stehessel
requested changes
Nov 13, 2023
|
@stehessel I added some changes to the |
stehessel
approved these changes
Nov 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are going to add a worker pool for "infrastructure" workloads on prod-dp-01.
This node pool will be labeled
node-role.kubernetes.io/acscs-infra. This will add a role to the node.For other clusters, the "default" node pool will be labeled with this as well.
This will have the consequence that our strictly-worker-nodes query will now return 0 nodes for all clusters apart from prod-dp-01.
This will add a specific label for those nodes which are considered as "worker" nodes.