chore: make SLI graphs more readable #177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rukletsov
approved these changes
Dec 12, 2023
rukletsov
reviewed
Dec 12, 2023
stehessel
force-pushed
the
chore/sli-graphs-readable
branch
from
b27482a
to
9bf74c0
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make the SLI graphs more readable by showing a proxy that renders better in Grafana. The problem right now is that Grafana swallows up spikes and instead renders a flat line. The proxy metric works by extending the "downtime" interval via
changes(...[1h]), such that Grafana has an easier way rendering it. The downside is that downtimes may appear longer than they were - however, the overall percentages (9' notation) are still exact.Before:
After:
The dashboard can be viewed temporarily under https://grafana-route-rhacs-observability.apps.acs-prod-dp-01.pnz3.p1.openshiftapps.com/d/a3d89363-95c2-470f-82d8-cd9c62fe3840/rhacs-dataplane-central-slos-copy?orgId=1.