Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add rhacs_expired_at to centrals overview panel #199

Merged
merged 2 commits into from
Feb 15, 2024
Merged

feat: add rhacs_expired_at to centrals overview panel #199

merged 2 commits into from
Feb 15, 2024

Conversation

0x656b694d
Copy link
Contributor

3 commits:

  1. JSON indentation;
  2. New column;
  3. make generate.

image

@0x656b694d 0x656b694d requested a review from a team as a code owner February 13, 2024 15:28
@stehessel
Copy link
Contributor

Can you try to adjust the indentation of the source json such that the diff will hopefully be smaller?

@0x656b694d
Copy link
Contributor Author

0x656b694d commented Feb 13, 2024 •
edited
Loading

Can you try to adjust the indentation of the source json such that the diff will hopefully be smaller?

@stehessel, please look at the second commit of the PR.
The indentation of the original JSON is absolutely unsupportable.

@stehessel
Copy link
Contributor

stehessel commented Feb 13, 2024 •
edited
Loading

The indentation of the original JSON is absolutely unsupportable.

Why is that?

@0x656b694d
Copy link
Contributor Author

The indentation of the original JSON is absolutely unsupportable.

Why is that?

A mess of tabs and spaces, one cannot just copy-paste a json snippet from Grafana to patch the file and keep formatting consistent.

image

@stehessel
Copy link
Contributor

stehessel commented Feb 14, 2024 •
edited
Loading

I'm concerned that the next PR will once again change the indentation. Let's just add a prettier formatter then (in other PR).

@stehessel
Copy link
Contributor

Btw for reviewing it can be nice to save the updated dashboard under a new name and share the link. The dashboard is not persisted and will be removed once the grafana pod is restarted.

@0x656b694d
Copy link
Contributor Author

I'm concerned that the next PR will once again change the indentation. Let's just add a prettier formatter then (in other PR).

@stehessel , See #200.

@0x656b694d
Copy link
Contributor Author

0x656b694d commented Feb 14, 2024 •
edited
Loading

Btw for reviewing it can be nice to save the updated dashboard under a new name and share the link. The dashboard is not persisted and will be removed once the grafana pod is restarted.

Please see the modified panel in "Test dashboards for PR review" → "PR 199" (DP production Grafana).

@0x656b694d 0x656b694d force-pushed the michael/add-expired-at-to-centrals-overview branch from 3e7599e to 355e820 Compare February 14, 2024 17:21
stehessel
stehessel approved these changes Feb 14, 2024
View reviewed changes
Copy link
Contributor

@stehessel stehessel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good thanks. One suggestion, I played with the test dashboard a bit and found that switching Minimum column width from 200 -> auto renders the columns a bit nicer for me.

@0x656b694d
Copy link
Contributor Author

Minimum column width from 200 -> auto renders the columns a bit nicer for me.

200 is the minimum width for "auto" resizing (they're two different settings). If I set less than 200, the "Expired At" column is cut for me.

@0x656b694d 0x656b694d merged commit 7af91bc into master Feb 15, 2024
1 check passed
@0x656b694d 0x656b694d deleted the michael/add-expired-at-to-centrals-overview branch February 15, 2024 08:53
@0x656b694d 0x656b694d mentioned this pull request Feb 15, 2024
Merged
0x656b694d added a commit that referenced this pull request Feb 15, 2024
@github-actions @ludydoo
@stehessel @dependabot @0x656b694d
sync: stage to production (#204)
d24144e 
* ROX-21739: SES Monitoring

* ROX-21739: PR Comments

* Bump pre-commit/action from 3.0.0 to 3.0.1 (#198)

Bumps [pre-commit/action](https://github.com/pre-commit/action) from 3.0.0 to 3.0.1.
- [Release notes](https://github.com/pre-commit/action/releases)
- [Commits](pre-commit/action@v3.0.0...v3.0.1)

---
updated-dependencies:
- dependency-name: pre-commit/action
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* chore: prettier json (#200)

* feat: add `rhacs_expired_at` to centrals overview panel (#199)

* fix central overview table position (#202)

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: Ludovic Cleroux <ludydoo@gmail.com>
Co-authored-by: Stephan Hesselmann <shesselm@redhat.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Michaël <smartptr@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stehessel stehessel stehessel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@0x656b694d @stehessel