ROX-23673: Add alerts for cluster autoscaler #218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtodor
changed the title
ludydoo
reviewed
Apr 15, 2024
There was a problem hiding this comment.
Not sure about removing the old alerts. Should we keep them, but put them as warnings with super high (99%) thresholds? @stehessel
stehessel
reviewed
Apr 15, 2024
mtodor
force-pushed
the
mtodor/ROX-13293-add-autoscaler-alerts
branch
from
3a6fcd3
to
c9da2c9
Compare
|
@stehessel @ludydoo I have revered old alerts and changed them. I don't have a strong opinion on whether we should keep old alerts or not. I just wanted to reduce the number of maintained alerts and the potential noise they can produce if they fire for the same reason. Can you please take a look again? 🥺 |
stehessel
reviewed
Apr 15, 2024
stehessel
reviewed
Apr 15, 2024
mtodor
force-pushed
the
mtodor/ROX-13293-add-autoscaler-alerts
branch
from
181bda8
to
87f12f7
Compare
stehessel
approved these changes
Apr 16, 2024
ludydoo
approved these changes
Apr 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds alerts related to cluster autoscaler behavior, and it removes alerts related to previous manual scaling.
Alerts are taken from default Openshift operator alerts: https://github.com/openshift/cluster-autoscaler-operator/blob/287595b0ee37b893c02d51d3a461ba118b90c3dc/pkg/controller/clusterautoscaler/monitoring.go#L153
Additional documentation related to alerts can be found here: https://github.com/openshift/cluster-autoscaler-operator/blob/287595b0ee37b893c02d51d3a461ba118b90c3dc/docs/user/alerts.md
They have different levels.