use deployment status instead of pod status #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stehessel
force-pushed
the
kube-deployment-status
branch
from
8a0d0b9
to
4d6991f
Compare
stehessel
force-pushed
the
kube-deployment-status
branch
from
4d6991f
to
5f62a82
Compare
ivan-degtiarenko
approved these changes
May 9, 2023
|
Michael pointed out that there can be a difference in some cases. I think one example would be if the deployment scales down the pods, then there is no pod status metric, but the deployment status metric would show zero. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
kube_deployment_status_replicas_readyto more accurately track the SLI in cases the pod status is not defined - for example deployment upgrades. Note that in most cases both metrics yield identical results.