-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: added gosec G101 #3566
feat: added gosec G101 #3566
Conversation
Hi @kadern0. Thanks for your PR. I'm waiting for a stackrox member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
Hi @kadern0. Thank you for addressing this. Now, please help us to fix the false positive G101 alerts:
|
Images are ready for the commit at 06d6b71. To use with deploy scripts, first |
@kadern0 Two files are not passing gosec check |
I think we can issue |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
style checks are failing
2e5b7e1
to
127d0f8
Compare
Signed-off-by: Pablo Caderno <kaderno@gmail.com>
127d0f8
to
dc10170
Compare
|
GitGuardian id | Secret | Commit | Filename | |
---|---|---|---|---|
- | Generic High Entropy Secret | 06d6b71 | central/metadata/service/service_impl_test.go | View secret |
- | Generic High Entropy Secret | 06d6b71 | sensor/common/centralclient/client_test.go | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secrets safely. Learn here the best practices.
- Revoke and rotate these secrets.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
Our GitHub checks need improvements? Share your feedbacks!
440d4d1
to
06d6b71
Compare
Signed-off-by: Pablo Caderno <kaderno@gmail.com>
Signed-off-by: Pablo Caderno <kaderno@gmail.com>
Signed-off-by: Pablo Caderno kaderno@gmail.com
Description
As described on #3545, added gosec G101