feat: added gosec G103

[kadern0]

Signed-off-by: Pablo Caderno kaderno@gmail.com

Description

As described on #3545, added gosec G103

[openshift-ci]

Hi @kadern0. Thanks for your PR.

I'm waiting for a stackrox member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[janisz]

/ok-to-test

[roxbot]

Images are ready for the commit at e7f892a.

To use with deploy scripts, first export MAIN_IMAGE_TAG=3.72.x-426-ge7f892a67c.

[0x656b694d]

Hi @kadern0. Thank you for addressing this! Now, please help us to fix the G103 alerts:

pkg/concurrency/error_signal.go:117:51: G103: Use of unsafe calls should be audited (gosec)
	if !atomic.CompareAndSwapPointer(&s.errPtr, nil, unsafe.Pointer(&err)) {
	                                                 ^
pkg/concurrency/error_signal.go:132:12: G103: Use of unsafe calls should be audited (gosec)
		errPtr:  unsafe.Pointer(&[]error{nil}[0]),
		         ^
pkg/concurrency/error_signal.go:147:13: G103: Use of unsafe calls should be audited (gosec)
		statePtr: unsafe.Pointer(newErrorSignalState()),
		          ^

[janisz]

@kadern0 pkg/concurrency/error_signal.go has some issues

[janisz]

style checks are failing

[gitguardian]

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secret in your pull request

GitGuardian id	Secret	Commit	Filename
-	Generic High Entropy Secret	e7f892a	central/metadata/service/service_impl_test.go	View secret

🛠 Guidelines to remediate hardcoded secrets

1. Understand the implications of revoking this secret by investigating where it is used in your code.
2. Replace and store your secret safely. Learn here the best practices.
3. Revoke and rotate this secret.
4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider

• following these best practices for managing and storing secrets including API keys and other credentials
• install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.

---

<sup>🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!</sup>

[misberner]

LGTM. Now that generics exists, it might be good to add a generic atomic (pointer) value to contain the use of unsafe.Pointers to low-level library code (not in this PR). Maybe Uber's atomic library already has something?