Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: shellcheck fixes for roxctl.sh #3569

Closed
wants to merge 3 commits into from

Conversation

kadern0
Copy link
Contributor

@kadern0 kadern0 commented Oct 26, 2022

Signed-off-by: Pablo Caderno kaderno@gmail.com

Description

Fix shellcheck warnings for roxctl.sh as per #3544

@openshift-ci
Copy link

openshift-ci bot commented Oct 26, 2022

Hi @kadern0. Thanks for your PR.

I'm waiting for a stackrox member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@github-actions github-actions bot added the external-contributor To put on issues and PRs from external contributors label Oct 26, 2022
Copy link
Contributor

@janisz janisz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@janisz
Copy link
Contributor

janisz commented Oct 26, 2022

/ok-to-test

@roxbot
Copy link
Contributor

roxbot commented Oct 26, 2022

Images are ready for the commit at 27608d6.

To use with deploy scripts, first export MAIN_IMAGE_TAG=3.72.x-423-g27608d6864.

@kadern0 kadern0 requested review from janisz and removed request for SimonBaeumer and gavin-stackrox October 27, 2022 05:06
Signed-off-by: Pablo Caderno <kaderno@gmail.com>
dev-tools/roxctl.sh Outdated Show resolved Hide resolved
Co-authored-by: Tomasz Janiszewski <janiszt@gmail.com>
dev-tools/roxctl.sh Outdated Show resolved Hide resolved
Co-authored-by: Tomasz Janiszewski <janiszt@gmail.com>
@porridge
Copy link
Contributor

CI seems stuck on the current tip. @kadern0 would you mind rebasing your branch to retry?

Copy link

openshift-ci bot commented Dec 12, 2023

@kadern0: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/shell-unit-tests 27608d6 link true /test shell-unit-tests

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@porridge
Copy link
Contributor

Closing this stale PR.
@kadern0 please reopen once you rebase and resolve conflicts.

@porridge porridge closed this Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
external-contributor To put on issues and PRs from external contributors ok-to-test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants