-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: shellcheck fixes for roxctl.sh #3569
Conversation
Hi @kadern0. Thanks for your PR. I'm waiting for a stackrox member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove dev-tools/roxctl.sh
from https://github.com/stackrox/stackrox/blob/master/scripts/style/shellcheck_skip.txt#L16
/ok-to-test |
Images are ready for the commit at 27608d6. To use with deploy scripts, first |
01aac7b
to
c0d4a78
Compare
Signed-off-by: Pablo Caderno <kaderno@gmail.com>
c0d4a78
to
997811e
Compare
Co-authored-by: Tomasz Janiszewski <janiszt@gmail.com>
Co-authored-by: Tomasz Janiszewski <janiszt@gmail.com>
CI seems stuck on the current tip. @kadern0 would you mind rebasing your branch to retry? |
@kadern0: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Closing this stale PR. |
Signed-off-by: Pablo Caderno kaderno@gmail.com
Description
Fix shellcheck warnings for roxctl.sh as per #3544