Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ROX-16129: Add container info to NG 2.0 deployment details #5373

Merged
merged 2 commits into from
Mar 24, 2023
Merged

ROX-16129: Add container info to NG 2.0 deployment details #5373

merged 2 commits into from
Mar 24, 2023

Conversation

vjwilson
Copy link
Contributor

Description

This adds the container information to the Deployment details tab of the Network Graph 2.0 sidebar.

Checklist

  • Investigated and inspected CI test results

Testing Performed

Container name and Resources
Screen Shot 2023-03-23 at 5 38 35 PM

Volumes
Screen Shot 2023-03-23 at 5 38 40 PM

Secrets
Screen Shot 2023-03-23 at 5 38 48 PM

Arguments and Commands
Screen Shot 2023-03-23 at 5 37 59 PM

@roxbot
Copy link
Contributor

roxbot commented Mar 23, 2023 •
edited
Loading

Images are ready for the commit at 6cd52e5.

To use with deploy scripts, first export MAIN_IMAGE_TAG=3.74.x-481-g6cd52e5eb0.

@zhenpesky
Copy link

zhenpesky commented Mar 23, 2023 •
edited
Loading

@vjwilson I think the image name is there but we also need a container name as shown in the new mock.

sachaudh
sachaudh approved these changes Mar 23, 2023
View reviewed changes
Copy link
Contributor

@sachaudh sachaudh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. If Zhenpeng approves the UX let's ship it 👍🏼

@vjwilson vjwilson merged commit 45c6343 into master Mar 24, 2023
@vjwilson vjwilson deleted the ROX-16129-add-container-info-to-NG-2 branch March 24, 2023 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sachaudh sachaudh sachaudh approved these changes

@zhenpesky zhenpesky zhenpesky approved these changes

@alwayshooin alwayshooin Awaiting requested review from alwayshooin

Assignees
No one assigned
Labels
area/ui
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@vjwilson @roxbot @zhenpesky @sachaudh