ROX-18276: Central info metric #7734
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Images are ready for the commit at 0177d62. To use with deploy scripts, first |
|
/retest |
1 similar comment
|
/retest |
stehessel
force-pushed
the
ROX-18276/central-info-metric
branch
from
b1966d4
to
ed344b0
Compare
stehessel
force-pushed
the
ROX-18276/central-info-metric
branch
from
ed344b0
to
bbba518
Compare
|
/retest |
stehessel
force-pushed
the
ROX-18276/central-info-metric
branch
from
bbba518
to
5b5bc74
Compare
|
/retest |
|
/retest |
1 similar comment
|
/retest |
janisz
reviewed
Sep 11, 2023
|
/retest |
3 similar comments
|
/retest |
|
/retest |
|
/retest |
janisz
approved these changes
Sep 11, 2023
|
/test ocp-4-13-ebpf-qa-e2e-tests |
|
/test gke-qa-e2e-tests |
|
@stehessel: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
Merge commit has been cherry-picked to branch |
roxbot
pushed a commit
that referenced
this pull request
Sep 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes to conform to the latest ask by the Telemeter team to approve our telemetry metrics (see openshift/cluster-monitoring-operator#2062).
rox_central_infowherecentral_idis the primary key. In queries the labels must be joined back onto the time seriesrhacs:telemetry:rox_central_info * on(central_id) group_left rhacs:telemetry:rox_central_secured_vcpus.rox_sensor_infometric for the sensor telemetry metric.Testing Performed
Tested with upstream image in OCP cluster with OpenShift monitoring. To simulate the downstream image, I manually set
ROX_PRODUCT_BRANDING=RHACS_BRANDING.CI
ocp-4-13-ebpf-qa-e2e-testsfailure is unrelated due to collector: