Vue & React app generator updates #54
Conversation
…ue with updated packaging
Sahana-Srinivasan
changed the title
Working app gen test
|
The git diff is hard to parse. It seems like some React and Webpack code is also altered? Is this PR built on top of a different PR that isn't merged to master, yet? |
This encapsulates the React generator updates made in PR 50, yeah. The general app generator/Webpack generator received minor updates just to make the Hello Blockstack page blue and look more similar to blockstack.org. Updated the PR comment. |
|
Looks like this needs the master branch merged in (or rebased on top of the master branch) |
…or into hello-blockstack-vue # Conflicts: # README.md # app/index.js # app/templates/_package.json # package-lock.json # package.json # react/index.js # react/templates/_package.json # react/templates/src/components/App.jsx # react/templates/src/styles/style.css # test/app.js # webpack/index.js # webpack/templates/_package.json # webpack/templates/dist/app.css # webpack/templates/dist/index.html # webpack/templates/dist/manifest.json # webpack/templates/src/index.js
@hstove Yeah, it modifies the blockstack logos/color for all the generators, improves the packaging for the React generator, creates a more robust test script, and adds the Vue generator. Also, Matt and I went through the merge conflicts so the diff should be more coherent now. |
Sahana-Srinivasan
changed the title
Sahana-Srinivasan
changed the title
|
@zone117x Does this look good to go? |
There was a problem hiding this comment.
Nice work @Sahana-Srinivasan. The updated UI looks great. Just a minor change in addition to what Matt added.
react/templates/_package.json
Outdated
| "bootstrap": "^3.3.7", | ||
| "react": "^15.5.4", | ||
| "react-dom": "^15.5.4" | ||
| "blockstack": "^19.2.1", |
There was a problem hiding this comment.
We can update this to 19.2.2 now.
Used blockstack-todos Vue packaging and modified Profile/Signed components from estermer's PR 15 to make a Hello, Blockstack app generator for Vue. Minifies the packaging of the React generator and updates the style of all four generators to match blockstack.org.