Skip to content
This repository has been archived by the owner on Apr 17, 2023. It is now read-only.

Enable testing name registrations #1679

Closed
aulneau opened this issue Sep 21, 2018 · 8 comments
Closed

Enable testing name registrations #1679

aulneau opened this issue Sep 21, 2018 · 8 comments

Comments

@aulneau
Copy link
Contributor

aulneau commented Sep 21, 2018

When we are working on / updating functionality / ui work for the onboarding, we tend to make a new account each time we have to go through the flow. This ends up being not a small number of new(fake) accounts.

I suggest we have a flag env that we pass when we're testing, eg process.env.STAGE or something to that effect which would switch out the registrar url for another name, eg *.test-blockstack.id. @kantai we have a test registrar set up already, correct? if so what is that url?

cc @yknl

@aulneau aulneau self-assigned this Sep 21, 2018
@yknl
Copy link
Collaborator

yknl commented Sep 21, 2018

Yes there is a test registrar setup, the url is in the settings defaults:
https://github.com/blockstack/blockstack-browser/blob/master/app/js/account/store/settings/default.js#L42

I've been creating a large number of testing ID's on the id.blockstack registrar as well. I don't think it has any significant negative effects. But if it does I'm on board with using the test registrar.

There is also the problem of running into rate limiting on the registrar when registering too many test usernames. We can get around this by setting an authorization header with an API key in the registration request. Authorization: bearer <secret>

I propose we add a URL param to indicate that it should run in testing mode and pass in the API key. (The automated end-to-end browser tests will also benefit from this) https://browser.blockstack.org/?testMode=true&registrarApiKey=secretkey

@aulneau
Copy link
Contributor Author

aulneau commented Sep 21, 2018

Nice, thanks.

I think a negative side effect of this is that it could does change the accuracy of the metrics around new user sign ups.

@aulneau
Copy link
Contributor Author

aulneau commented Sep 21, 2018

@yknl do you have availability to work on this?

@yknl
Copy link
Collaborator

yknl commented Sep 21, 2018

I may be able to get this next week.

@markmhendrickson
Copy link

@yknl were you able to address this after all?

@hstove
Copy link
Collaborator

hstove commented Mar 7, 2019 via email

@markmhendrickson
Copy link

@hstove Cool, is this issue good to close out then?

@hstove
Copy link
Collaborator

hstove commented Mar 8, 2019

Yes, I think so.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants