This repository has been archived by the owner on Apr 17, 2023. It is now read-only.
Support for unsigned builds of the MacOS app #1803
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…quire Apple developer certificates setup.
|
I'll have to defer to @yknl on this review, as I've never done macOS builds. |
|
To help reviewers - here is a working TravisCI build config that uses a typical/stock MacOS environment: |
yknl
reviewed
Jan 24, 2019
hstove
approved these changes
Jan 24, 2019
Merged
* Add error messaging for when the browser server script processes terminate from error
|
@hstove I made a considerable change to this PR with the removal of nexe. I think you should revoke the PR approval and re-review |
hstove
approved these changes
Jan 28, 2019
|
The production build is now working. I tested the CORS proxy with curl: |
yknl
approved these changes
Jan 28, 2019
|
If I remember correctly, the CORS proxy works a bit differently in the windows build. We'll have to test that out as well. |
Doesn't this not touch the Windows build? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few new build scripts for building the native MacOS app without having the $100 Apple developer certificate or needing access to the private PBC cert.
Useful for CI automated building &
Blockstack.appartifact publishing as well. See commit 96c5c82 for the travisCI build config, which we can PR after this one, if wanted.