Skip to content
This repository has been archived by the owner on Apr 15, 2021. It is now read-only.

Contract transaction tests #12

Merged
merged 7 commits into from
Mar 19, 2020
Merged

Conversation

reedrosenbluth
Copy link
Contributor

@reedrosenbluth reedrosenbluth commented Mar 13, 2020

This PR updates the contract deploy test and adds a test for contract-call transaction serialization.

It includes a few fixes for txid generation which was breaking Transaction signing. It also fixes the values in the PayloadType enum, accounting for a typo in SIP 005 which has been fixed (stacks-network/stacks-core#1326)

Additionally, I moved the collectCoverage option out of the Jest config and into package.json, as it was breaking my VSCode debugger (kulshekhar/ts-jest#484)

@reedrosenbluth reedrosenbluth marked this pull request as ready for review March 18, 2020 21:43
Copy link
Contributor

@zone117x zone117x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

package.json Show resolved Hide resolved
package.json Show resolved Hide resolved
Copy link
Collaborator

@yknl yknl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@reedrosenbluth reedrosenbluth merged commit f709983 into master Mar 19, 2020
@reedrosenbluth reedrosenbluth deleted the contract-transaction-tests branch March 19, 2020 15:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants